[PATCH] D9996: Refactor: Simplify boolean conditional return statements in lib/Transforms/Instrumentation

Richard via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 24 12:35:04 PDT 2015


LegalizeAdulthood updated this revision to Diff 38320.
LegalizeAdulthood added a comment.

Update from latest
I do not have commit access.


http://reviews.llvm.org/D9996

Files:
  lib/Transforms/Instrumentation/AddressSanitizer.cpp

Index: lib/Transforms/Instrumentation/AddressSanitizer.cpp
===================================================================
--- lib/Transforms/Instrumentation/AddressSanitizer.cpp
+++ lib/Transforms/Instrumentation/AddressSanitizer.cpp
@@ -908,10 +908,8 @@
   } else {
     return false;
   }
-  if (!isPointerOperand(I->getOperand(0)) ||
-      !isPointerOperand(I->getOperand(1)))
-    return false;
-  return true;
+  return isPointerOperand(I->getOperand(0)) &&
+         isPointerOperand(I->getOperand(1));
 }
 
 bool AddressSanitizer::GlobalIsLinkerInitialized(GlobalVariable *G) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D9996.38320.patch
Type: text/x-patch
Size: 591 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151024/b2d027a1/attachment.bin>


More information about the llvm-commits mailing list