[PATCH] D14034: [ELF2] Implement --start-group,--end-group

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: test/elf2/Inputs/startendgroup/a.s:5
@@ +4,2 @@
+main:
+	jmp	bar
----------------
Filenames of inputs are very uninformative. Usually the same name as test name are used, eg:
shared.s
Inputs\shared.s 
Inputs\shared2.s

================
Comment at: test/elf2/startendgroup.s:19
@@ +18,2 @@
+#CHECK: boo
+#CHECK: moo
----------------
As Rui already said, --start-group and --end-group are already supported.

Your test will PASS and without your code. Thats because lld currently already works in the way when it does not need --start-group and --end-group in command line to resolve it. These options are silently ignored, see Options.td.


http://reviews.llvm.org/D14034