[PATCH] D14035: Fix llc crash processing S/UREM for -Oz builds caused by rL250825.
Steve King via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 23 19:24:36 PDT 2015
srking added inline comments.
================
Comment at: test/CodeGen/Generic/urem_crash.ll:1
@@ +1,2 @@
+; RUN: llc < %s
+
----------------
arsenm wrote:
> srking wrote:
> > arsenm wrote:
> > > This definitely needs to check something and should not be under CodeGen/Generic
> > Where should the test live?
> > The simple no-check style was keeping with another "crash" test I used for reference.
> There should probably be a test for a target with and without isIntDivCheap.
Sounds good. x86 would work. I'll update patch.
Repository:
rL LLVM
http://reviews.llvm.org/D14035
More information about the llvm-commits
mailing list