[PATCH] D13958: Mere SHF_STRING

Michael Spencer via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 23 18:23:18 PDT 2015


Bigcheese added inline comments.

================
Comment at: ELF/InputFiles.cpp:125
@@ +124,3 @@
+static typename InputSection<ELFT>::Kind
+getSectionType(const typename ELFFile<ELFT>::Elf_Shdr &Sec) {
+  typedef typename ELFFile<ELFT>::uintX_t uintX_t;
----------------
I dislike the name of this function. SectionType seems to indicate the SHT_* values. getSectionKind would be fine.


http://reviews.llvm.org/D13958





More information about the llvm-commits mailing list