[PATCH] D13998: Move parts of llvm-symbolizer tool into LLVMSymbolize library.
Eric Christopher via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 23 17:40:01 PDT 2015
echristo added a reviewer: rafael.
echristo added a comment.
Couple of inline comments otherwise it looks fine to me.
Rafael: You had objected originally about this, do you still mind?
-eric
================
Comment at: lib/DebugInfo/Symbolize/Symbolize.cpp:14
@@ -13,2 +13,3 @@
-#include "LLVMSymbolize.h"
+#include "llvm/DebugInfo/Symbolize/Symbolize.h"
+
----------------
Should be down with the other headers?
================
Comment at: lib/DebugInfo/Symbolize/Symbolize.cpp:49
@@ -47,2 +48,3 @@
+// FIXME: Move this to llvm-symbolizer tool.
static bool error(std::error_code ec) {
----------------
Please do :)
http://reviews.llvm.org/D13998
More information about the llvm-commits
mailing list