[PATCH] D14021: Added cfi instructions for correct CFA calculation in case when movpc instruction expands to call and pop

[Reid Kleckner via llvm-commits]

rnk added inline comments.

================
Comment at: lib/Target/X86/X86MCInstLower.cpp:1151
@@ +1150,3 @@
+    if (NeedsDwarfCFI && !hasFP) {
+      MCCFIInstruction::createAdjustCfaOffset(nullptr, -stackGrowth);
+      OutStreamer->EmitCFIAdjustCfaOffset(-stackGrowth);
----------------
Do you need to create this MCCFIInstruction that you ultimately don't use?

================
Comment at: lib/Target/X86/X86MCInstLower.cpp:1163
@@ +1162,3 @@
+    if (NeedsDwarfCFI && !hasFP) {
+      MCCFIInstruction::createAdjustCfaOffset(nullptr, stackGrowth);
+      OutStreamer->EmitCFIAdjustCfaOffset(stackGrowth);
----------------
ditto?


Repository:
  rL LLVM

http://reviews.llvm.org/D14021