[PATCH] D14003: Express and handle specific info about the processing of invariant intrinsics

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 22 21:53:01 PDT 2015


sanjoy added a subscriber: sanjoy.

================
Comment at: include/llvm/IR/InvariantInfo.h:27
@@ +26,3 @@
+/// intrinsic calls.
+class InvariantInfo {
+  DenseMap<Value *, IntrinsicInst *> InvariantMarkers;
----------------
Please add some high level comments describing how this is supposed to be used.

================
Comment at: include/llvm/IR/InvariantInfo.h:28
@@ +27,3 @@
+class InvariantInfo {
+  DenseMap<Value *, IntrinsicInst *> InvariantMarkers;
+public:
----------------
Please add some comments on how you deal with passes RAUW'ing or erasing values.

================
Comment at: include/llvm/IR/InvariantInfo.h:55
@@ +54,3 @@
+
+bool processInvariantIntrinsic(IntrinsicInst *II, InvariantInfo &InvInfo);
+bool BackwardScanInvariantIntrinsic(const IntrinsicInst *II,
----------------
Please document these functions.


http://reviews.llvm.org/D14003





More information about the llvm-commits mailing list