[PATCH] D13963: Create a new interface addSuccessorWithoutWeight(MBB*) in MBB to add successors when optimization is disabled.

Xinliang David Li via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 22 12:58:43 PDT 2015


On Thu, Oct 22, 2015 at 12:44 PM, Cong Hou <congh at google.com> wrote:

> I think it would be better to also add the weight based interface for test
> sake.
>

you meant to surface potential problems earlier?  that sounds reasonable. I
will go back and look at the patch more.

David


> This is also for the later transition from weight-based interfaces to
> BP-based interfaces.
>
> thanks,
> Cong
>
> On Thu, Oct 22, 2015 at 12:35 PM, Xinliang David Li <davidxl at google.com>
> wrote:
>
>> Merge it into http://reviews.llvm.org/D13908, but make the interface BP
>> based instead of weight based.
>>
>> On Thu, Oct 22, 2015 at 12:30 PM, Cong Hou <congh at google.com> wrote:
>>
>>> congh added a comment.
>>>
>>> In http://reviews.llvm.org/D13963#273354, @davidxl wrote:
>>>
>>> > This looks reasonable, but I think it is better to be folded into
>>> branch probability interface patch.
>>>
>>>
>>> You mean merge this patch with that one, and add the BP version of this
>>> new interface?
>>>
>>>
>>> http://reviews.llvm.org/D13963
>>>
>>>
>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151022/79d7611e/attachment.html>


More information about the llvm-commits mailing list