[PATCH] D13986: [ELF2] - TLS relocations implemented
Davide Italiano via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 22 09:38:31 PDT 2015
davide added a comment.
In http://reviews.llvm.org/D13986#273235, @grimar wrote:
> In http://reviews.llvm.org/D13986#273214, @davide wrote:
>
> > If it's not a big amount of work, can you split PT_TLS and relocations in two different patches? If it is too much, forget about it.
> > Also, while I haven't reviewed his work very carefully, I think Michael Spencer is working on TLS as well, so I think you guys should coordinate to minimize the overlap.
>
>
> I could split but just not sure how.
> When I add some TLS data (variables) then R_X86_64_TPOFF32/R_X86_64_DTPOFF32 relocations are created and we need the size of TLS and its address to process them.
> TLS info currently is calculated during headers creating.
> At the same time TLS header will only present if we have some TLS data. And data means relocations.
> So just not sure it is easy to split. Ideas are welcome.
Leave it as is then.
http://reviews.llvm.org/D13986
More information about the llvm-commits
mailing list