[PATCH] D12706: Handle non-constant shifts in computeKnownBits, and use computeKnownBits for constant folding in InstCombine/Simplify

[James Molloy via llvm-commits]

Hi Hal,

I'm keen to get this committed so I can work on the follow-on suggestion I
made myself.

Will you get time to commit this soon? or is it OK if I commit it on your
behalf instead?

Cheers,

James

On Wed, 14 Oct 2015 at 18:49 Philip Reames via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> reames accepted this revision.
> reames added a comment.
> This revision is now accepted and ready to land.
>
> LGTM w/minor comment addressed
>
> Are you planning on implementing the follow on suggestions?  If not, we
> should make sure they get tracked either as TODOs or bugs.
>
>
> ================
> Comment at: lib/Analysis/ValueTracking.cpp:990
> @@ +989,3 @@
> +
> +  computeKnownBits(I->getOperand(1), KnownZero, KnownOne, DL, Depth + 1,
> Q);
> +
> ----------------
> It would be more clearly correct to use the two temporaries for this
> calculation.  The current code is correct, but slightly confusing.
>
>
> http://reviews.llvm.org/D12706
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151022/cd171b6b/attachment.html>