[PATCH] D13961: [OperandBundles] Make function attributes conservatively correct
Philip Reames via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 21 18:25:21 PDT 2015
reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.
LGTM w/minor comments addressed
================
Comment at: test/Feature/OperandBundles/adce.ll:5
@@ +4,3 @@
+declare void @readnone_function() readnone nounwind
+
+define void @test0() {
----------------
Add a comment about *why* these need not be dead.
================
Comment at: test/Feature/OperandBundles/early-cse.ll:5
@@ +4,3 @@
+declare void @readnone_function() readnone nounwind
+
+define i32 @test0(i32* %x) {
----------------
Again, adding comments about what you're testing and why would be helpful.
http://reviews.llvm.org/D13961
More information about the llvm-commits
mailing list