[PATCH] D13960: [ELF2] Symbol Versioning: part 1, VERSION() directive parsing

[Rui Ueyama via llvm-commits]

On Wed, Oct 21, 2015 at 4:13 PM, Davide Italiano <davide at freebsd.org> wrote:

> On Wed, Oct 21, 2015 at 3:53 PM, Rui Ueyama via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> > ruiu added a comment.
> >
> > Oh yeah, that's very unfortunate, but that's true.
> >
> > I took a look at gold's source code and found that their lexer behaves
> differently depending on the context -- if it's outside of version script,
> ':' is a token character, but inside version script, only '::' are handled
> as part of a token. I don't know if we really want to have this craziness.
> >
>
> Yes, I noticed that as well and I was a little bit scared by the
> complexity.
>
> > I'd really like to always handle ':' as a token character, and let users
> to update their linker script if not compatible with that behavior. Davide,
> could you grep all linker scripts in FreeBSD which has a space between
> 'global' or 'local' and the following semicolon and count that number?
> >
>
> Me too. FWIW, a quick scan in FreeBSD showed up none of the version
> scripts has the space. Even if it would have, it doesn't matter, given
> I have the power to change it. I can't speak for Linux, other OSes and
> all the majority of people using version scripts. In other words, I
> just tried to be a "good citizen" and look outside of FreeBSD. If you,
> Rafael et al. don't have objections to support semicolons as token
> character I'll just go for it (and we can re-evaluate the decision
> later, if needed).
>

I have no objection -- I do support handling ':' just as a regular token
character in order to avoid complex tokenization logic.


> >
> > http://reviews.llvm.org/D13960
> >
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
> --
> Davide
>
> "There are no solved problems; there are only problems that are more
> or less solved" -- Henri Poincare
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151021/a8e4916a/attachment-0001.html>