[PATCH] D13774: [CodeGen] Mark setjmp/catchret MBBs address-taken

[Reid Kleckner via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm
I looked at the setjmp test case, and that convinced me that your approach here is better.


================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:2483
@@ -2482,3 +2482,3 @@
 
-    for (MCSymbol *Sym : MMI->getAddrLabelSymbolToEmit(BB))
-      OutStreamer->EmitLabel(Sym);
+    if (BB->hasAddressTaken())
+      for (MCSymbol *Sym : MMI->getAddrLabelSymbolToEmit(BB))
----------------
There should be a comment here explaining that MBBs can have their address taken as part of CodeGen without having their address taken in IR.


http://reviews.llvm.org/D13774