[llvm] r250805 - Make class final to pacify -Wnon-virtual-dtor.

[Benjamin Kramer via llvm-commits]

On Wed, Oct 21, 2015 at 7:22 PM, David Blaikie via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
>
>
> On Tue, Oct 20, 2015 at 9:18 PM, Manuel Klimek <klimek at google.com> wrote:
>>
>> I needed to set the binutils include dir (and install binutils-dev)
>
>
> Great - that did it. Reckon there's any upstream bots we could/should update
> with this config to catch these things sooner in general?

At least one of the sanitizer bots (sanitizer-x86_64-linux) builds the
gold plugin with -Werror, I guess the failure got lost in the noise or
it was red already.

- Ben

>> On Tue, Oct 20, 2015, 9:06 PM David Blaikie <dblaikie at gmail.com> wrote:
>>>
>>> On Tue, Oct 20, 2015 at 1:21 AM, Manuel Klimek via llvm-commits
>>> <llvm-commits at lists.llvm.org> wrote:
>>>>
>>>> Author: klimek
>>>> Date: Tue Oct 20 03:21:01 2015
>>>> New Revision: 250805
>>>>
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=250805&view=rev
>>>> Log:
>>>> Make class final to pacify -Wnon-virtual-dtor.
>>>
>>>
>>> Shiny - thanks! Any details on why this isn't built on any buildbot (or
>>> perhaps I missed the fail-mail) and/or how to configure it to be built in a
>>> local build? (so I can ensure I don't break it in the future)
>>>
>>>
>>>>
>>>>
>>>> Modified:
>>>>     llvm/trunk/tools/gold/gold-plugin.cpp
>>>>
>>>> Modified: llvm/trunk/tools/gold/gold-plugin.cpp
>>>> URL:
>>>> http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/gold/gold-plugin.cpp?rev=250805&r1=250804&r2=250805&view=diff
>>>>
>>>> ==============================================================================
>>>> --- llvm/trunk/tools/gold/gold-plugin.cpp (original)
>>>> +++ llvm/trunk/tools/gold/gold-plugin.cpp Tue Oct 20 03:21:01 2015
>>>> @@ -544,7 +544,7 @@ static const char *getResolutionName(ld_
>>>>  }
>>>>
>>>>  namespace {
>>>> -class LocalValueMaterializer : public ValueMaterializer {
>>>> +class LocalValueMaterializer final : public ValueMaterializer {
>>>>    DenseSet<GlobalValue *> &Dropped;
>>>>    DenseMap<GlobalObject *, GlobalObject *> LocalVersions;
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> llvm-commits mailing list
>>>> llvm-commits at lists.llvm.org
>>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>

On Wed, Oct 21, 2015 at 7:22 PM, David Blaikie via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
>
>
> On Tue, Oct 20, 2015 at 9:18 PM, Manuel Klimek <klimek at google.com> wrote:
>>
>> I needed to set the binutils include dir (and install binutils-dev)
>
>
> Great - that did it. Reckon there's any upstream bots we could/should update
> with this config to catch these things sooner in general?
>
>>
>>
>> On Tue, Oct 20, 2015, 9:06 PM David Blaikie <dblaikie at gmail.com> wrote:
>>>
>>> On Tue, Oct 20, 2015 at 1:21 AM, Manuel Klimek via llvm-commits
>>> <llvm-commits at lists.llvm.org> wrote:
>>>>
>>>> Author: klimek
>>>> Date: Tue Oct 20 03:21:01 2015
>>>> New Revision: 250805
>>>>
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=250805&view=rev
>>>> Log:
>>>> Make class final to pacify -Wnon-virtual-dtor.
>>>
>>>
>>> Shiny - thanks! Any details on why this isn't built on any buildbot (or
>>> perhaps I missed the fail-mail) and/or how to configure it to be built in a
>>> local build? (so I can ensure I don't break it in the future)
>>>
>>>
>>>>
>>>>
>>>> Modified:
>>>>     llvm/trunk/tools/gold/gold-plugin.cpp
>>>>
>>>> Modified: llvm/trunk/tools/gold/gold-plugin.cpp
>>>> URL:
>>>> http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/gold/gold-plugin.cpp?rev=250805&r1=250804&r2=250805&view=diff
>>>>
>>>> ==============================================================================
>>>> --- llvm/trunk/tools/gold/gold-plugin.cpp (original)
>>>> +++ llvm/trunk/tools/gold/gold-plugin.cpp Tue Oct 20 03:21:01 2015
>>>> @@ -544,7 +544,7 @@ static const char *getResolutionName(ld_
>>>>  }
>>>>
>>>>  namespace {
>>>> -class LocalValueMaterializer : public ValueMaterializer {
>>>> +class LocalValueMaterializer final : public ValueMaterializer {
>>>>    DenseSet<GlobalValue *> &Dropped;
>>>>    DenseMap<GlobalObject *, GlobalObject *> LocalVersions;
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> llvm-commits mailing list
>>>> llvm-commits at lists.llvm.org
>>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>