[PATCH] D13697: [SimplifyCFG] Merge conditional stores

[James Molloy via llvm-commits]

jmolloy marked 4 inline comments as done.

================
Comment at: lib/Transforms/Utils/SimplifyCFG.cpp:2440
@@ +2439,3 @@
+  // the store out of the Q blocks won't change any behavior as we're sinking
+  // from a block to its unconditional successor. But we're moving a store from
+  // the P blocks down through the middle block (QBI) and past both QFB and QTB.
----------------
Actually, PStore must come from a conditional block (see line 2410).

================
Comment at: lib/Transforms/Utils/SimplifyCFG.cpp:2509
@@ +2508,3 @@
+
+static bool mergeConditionalStores(BranchInst *PBI, BranchInst *QBI) {
+  // The intention here is to find diamonds or triangles (see below) where each
----------------
This is a good possible extension to this optimization! Probably best to wait until it's gone in in its current, more simple form though.


Repository:
  rL LLVM

http://reviews.llvm.org/D13697