[PATCH] D13363: [DeadStoreElimination] Add support for DSE across blocks

[Ivan Baev via llvm-commits]

ivanbaev marked 8 inline comments as done.
ivanbaev added a comment.

ping?


================
Comment at: lib/Transforms/Scalar/DeadStoreElimination.cpp:616
@@ +615,3 @@
+            // shortening it to not vector size is likely to be slower
+            MemIntrinsic* DepIntrinsic = cast<MemIntrinsic>(DepWrite);
+            unsigned DepWriteAlign = DepIntrinsic->getAlignment();
----------------
majnemer wrote:
> Pointers go on the right side, please use `auto *` to avoid repetition.
this is actually the current code; done

================
Comment at: lib/Transforms/Scalar/DeadStoreElimination.cpp:627-630
@@ +626,6 @@
+
+              Value* DepWriteLength = DepIntrinsic->getLength();
+              Value* TrimmedLength = ConstantInt::get(DepWriteLength->getType(),
+                                                      InstWriteOffset -
+                                                      DepWriteOffset);
+              DepIntrinsic->setLength(TrimmedLength);
----------------
majnemer wrote:
> Pointers lean right.
this is actually the current code; done


http://reviews.llvm.org/D13363