[PATCH] D13666: Add an (optional) identification block in the bitcode

[Mehdi Amini via llvm-commits]

Hi Chandler,

Waiting to hear your opinion about the epoch solution vs encoding the exact LLVM version as Rafael suggested (see two emails below).
Either way is fine for me at this point.

— 
Mehdi


> On Oct 19, 2015, at 10:45 PM, Mehdi Amini <mehdi.amini at apple.com> wrote:
> 
> Hi Chandler, 
> 
> I updated the revision, but you didn’t answer on the epoch solution vs encoding the exact version (see below).
> 
> Thanks,
> 
> — 
> Mehdi
> 
>> On Oct 14, 2015, at 1:44 PM, Mehdi Amini via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>> 
>> Hi Chandler,
>> 
>> I added the epoch field in the identification block. 
>> Rafael on IRC mentioned that it would be nice to have the option of progressively deprecating bitcode in the future. For instance LLVM 4.1 could be able to read bitcode generated by version 3.14 (random number) and above. And 4.2 deprecate in turn anything older than 3.19 (random number again).
>> 
>> We can do that by encoding the version directly (major.minor.patch) in separate bytes and use it instead of the epoch.
>> 
>> What’s your take on this?
>> 
>> Thanks,
>> 
>> — 
>> Mehdi
>> 
>> 
>>> On Oct 14, 2015, at 12:59 PM, Mehdi AMINI <mehdi.amini at apple.com> wrote:
>>> 
>>> joker.eph updated this revision to Diff 37380.
>>> joker.eph added a comment.
>>> 
>>> Add the "epoch" field along with the producer string.
>>> 
>>> 
>>> http://reviews.llvm.org/D13666
>>> 
>>> Files:
>>> include/llvm/Bitcode/LLVMBitCodes.h
>>> lib/Bitcode/Reader/BitcodeReader.cpp
>>> lib/Bitcode/Writer/BitcodeWriter.cpp
>>> test/Bitcode/identification.ll
>>> tools/llvm-bcanalyzer/llvm-bcanalyzer.cpp
>>> 
>>> <D13666.37380.patch>
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>