[PATCH] D13815: [ELF2] Add support for Gnu Hash section
Igor Kudrin via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 20 15:14:07 PDT 2015
ikudrin marked 10 inline comments as done.
================
Comment at: ELF/OutputSections.cpp:324
@@ +323,3 @@
+ return RoundUpToAlignment(NumHashed, sizeof(Elf_Off)) / sizeof(Elf_Off);
+}
+
----------------
Thank you for the suggestion, it looks much better now.
================
Comment at: ELF/OutputSections.cpp:389
@@ +388,3 @@
+ Values[PrevValueIndex] |= 1;
+ Buckets[BucketIndex] = Item.Body->getDynamicSymbolTableIndex();
+ PrevBucketIndex = BucketIndex;
----------------
Shame on me, you are absolutely correct.
http://reviews.llvm.org/D13815
More information about the llvm-commits
mailing list