[PATCH] D13911: [ELF2] Determine the order of entries of symbol tables in the finalize() phase.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 20 14:26:11 PDT 2015


ruiu added a comment.

This comment is not directly related to this change (so you can ignore), but I noticed that the symbol handling in SymbolTableSection is very odd. We do call addSymbol only when includeInSymtab() is true for a symbol, but we basically discard that information and iterate over the symbol table again inside SymbolTableSection when writing an output (and call includeInSymtab() again so that the output is consistent). This needs to be straightened.


http://reviews.llvm.org/D13911





More information about the llvm-commits mailing list