[PATCH] D13911: [ELF2] Determine the order of entries of symbol tables in the finalize() phase.

Igor Kudrin via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 20 14:03:36 PDT 2015


ikudrin added inline comments.

================
Comment at: ELF/OutputSections.cpp:694-697
@@ +693,6 @@
+
+  std::stable_sort(Symbols.begin(), Symbols.end(), [](SymbolBody *L,
+                                                      SymbolBody *R) {
+    return getSymbolBinding(L) == STB_LOCAL && getSymbolBinding(R) != STB_LOCAL;
+  });
+  if (StrTabSec.isDynamic()) {
----------------
ruiu wrote:
> Do we have to sort them even if isDynamic() is false?
It's a replacement for removed lines 813-818.


http://reviews.llvm.org/D13911





More information about the llvm-commits mailing list