[PATCH] D13815: [ELF2] Add support for Gnu Hash section

[Igor Kudrin via llvm-commits]

ikudrin added inline comments.

================
Comment at: ELF/OutputSections.cpp:237
@@ +236,3 @@
+    H = (H << 5) + H + C;
+  return H & 0xffffffff;
+}
----------------
rafael wrote:
> Given that you are using a uint32_t, this is a nop, no?
Thanks for reminding. The reference implementation uses uint_fast32_t, I think we should do the same.

================
Comment at: ELF/OutputSections.cpp:907
@@ +906,3 @@
+template <class ELFT>
+unsigned char SymbolTableSection<ELFT>::getSymbolBinding(SymbolBody *Body) {
+  unsigned char Visibility = Body->getMostConstrainingVisibility();
----------------
rafael wrote:
> Adding getSymbolBinding is a nice implement on its own. Please commit and rebase.
Please check it: http://reviews.llvm.org/D13910


http://reviews.llvm.org/D13815