[PATCH] D13740: Catch combine opportunities for redundant imuls

[Zia Ansari via llvm-commits]

zansari updated this revision to Diff 37906.
zansari added a comment.

Thanks, Sanjay.

I've incorporated your comments.

Also, apologies to Simon as I seem to have missed the point about "non-splatted" cases. I made the suggested change to use the more general vector constant check (these were never being caught before due to a conservative constant check which I had to change), and I also added another test case to check for the non-splatted cases which verifies the desired elimination of the extra two multiplies.

Thanks, again, and I appreciate your patience with me as I'm slowly learning llvm code and process.
Zia.


http://reviews.llvm.org/D13740

Files:
  lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  test/CodeGen/X86/combine-multiplies.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D13740.37906.patch
Type: text/x-patch
Size: 11375 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151020/1d3bf147/attachment.bin>