[llvm] r250805 - Make class final to pacify -Wnon-virtual-dtor.

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 20 12:06:18 PDT 2015


On Tue, Oct 20, 2015 at 1:21 AM, Manuel Klimek via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: klimek
> Date: Tue Oct 20 03:21:01 2015
> New Revision: 250805
>
> URL: http://llvm.org/viewvc/llvm-project?rev=250805&view=rev
> Log:
> Make class final to pacify -Wnon-virtual-dtor.
>

Shiny - thanks! Any details on why this isn't built on any buildbot (or
perhaps I missed the fail-mail) and/or how to configure it to be built in a
local build? (so I can ensure I don't break it in the future)



>
> Modified:
>     llvm/trunk/tools/gold/gold-plugin.cpp
>
> Modified: llvm/trunk/tools/gold/gold-plugin.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/gold/gold-plugin.cpp?rev=250805&r1=250804&r2=250805&view=diff
>
> ==============================================================================
> --- llvm/trunk/tools/gold/gold-plugin.cpp (original)
> +++ llvm/trunk/tools/gold/gold-plugin.cpp Tue Oct 20 03:21:01 2015
> @@ -544,7 +544,7 @@ static const char *getResolutionName(ld_
>  }
>
>  namespace {
> -class LocalValueMaterializer : public ValueMaterializer {
> +class LocalValueMaterializer final : public ValueMaterializer {
>    DenseSet<GlobalValue *> &Dropped;
>    DenseMap<GlobalObject *, GlobalObject *> LocalVersions;
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151020/2fcf6f4e/attachment.html>


More information about the llvm-commits mailing list