[PATCH] D13904: [ELF2] .shstrtab section implemented

[Rui Ueyama via llvm-commits]

I'm not really using MSVC as an IDE (despite all my work for COFF!), so I
have no good advice, but seems that at least you can search for all
occurrences of trailing whitespaces using the regular expression search
inside the IDE, so I'd probably do that before submitting.

On Tue, Oct 20, 2015 at 10:46 AM, George Rimar <grimar at accesssoftek.com>
wrote:

> Yes, that is my primary dev tool.
> I am using qtcreator and ubuntu virtual machine only for self-hosting
> tests and to have access to gnu tools when needed.
> It works for me.
> ________________________________________
> От: Rui Ueyama [ruiu at google.com]
> Отправлено: 20 октября 2015 г. 21:41
> Кому: reviews+D13904+public+03561865476a15e1 at reviews.llvm.org
> Копия: George Rimar; Rafael Ávila de Espíndola; Davide Italiano;
> llvm-commits
> Тема: Re: [PATCH] D13904: [ELF2] .shstrtab section implemented
>
> On Tue, Oct 20, 2015 at 10:27 AM, George Rimar <grimar at accesssoftek.com
> <mailto:grimar at accesssoftek.com>> wrote:
> grimar added a comment.
>
> In http://reviews.llvm.org/D13904#271253, @ruiu wrote:
>
> > Also please verify that the patch does not contain trailing whitespace.
> (I don't know if that exists in this patch, but your previous patch
> contained that.) If you are using git, the easiest way is to run 'git show'
> before submission, as the command highlights trailing whitespace.
>
>
> I noticed your message too late. Actually I am using svn, but I had
> installed plugin for MSVS that keeps unix endlines in code, so I hope
> everything should be fine here.
>
> Out of curiosity, by MSVS, you mean Microsoft Visual Studio? (I mean,
> nothing wrong with MSVS, but I assumed that Unix tool developers are
> usually using Unix.)
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151020/bd7bde66/attachment.html>