[PATCH] D13904: [ELF2] .shstrtab section implemented

[Davide Italiano via llvm-commits]

On Tue, Oct 20, 2015 at 10:43 AM, George Rimar <grimar at accesssoftek.com> wrote:
>>> Yes, some of them were changed after test, but some another probably is just cosmetics. Sorry I was read your mail after commiting already.
>>> I did not think that is so important. I can revert and commit separately if needed, or leave as is.
>>
>>No need to revert I think, but unrelated changes make the patch less
>>readable. Just a good practice to make our life easier if in 6 months
>>we look at this again, not a mandatory requirement.
>
> I see.
> Actually that indices breaks tests often. I would vote to forbide using of them in tests if test itself does not requires it.

I agree we should keep out of tests unstable information unless
there's a good reason not to.

-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare