[PATCH] D13904: [ELF2] .shstrtab section implemented

[Davide Italiano via llvm-commits]

On Tue, Oct 20, 2015 at 10:14 AM, George Rimar via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> grimar added inline comments.
>
> ================
> Comment at: test/elf2/basic-mips.s:4
> @@ -3,3 +3,3 @@
>  # RUN: llvm-readobj -file-headers -sections -program-headers -symbols %t.exe \
> -# RUN:   | FileCheck %s
> +# RUN:   > C:\access_softek\temps\out.txt
>
> ----------------
> davide wrote:
>> what's this?
> Oops. Will fix before commit.
>
> ================
> Comment at: test/elf2/basic.s:192
> @@ -191,3 +205,2 @@
>
> -
>  # Test for the response file
> ----------------
> davide wrote:
>> Also this newline can be avoided.
> Will fix.
>
>

Thank you. Sorry to bother you one more time, but I saw you removed
the dump of the index in the string table for many symbols.

e.g.
# CHECK-NEXT: Name: _start (7)
became
# CHECK-NEXT: Name: _start

I silently assumed you did this because indices changed after the test.
If yes, it's fine. Otherwise, if some of them are just cosmetic,
commit separately.

Moreover, in basic-mips.s still .bss has the index dumped (not sure if
it's an oversight), as well as .strtab in basic64be.s



-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare