[PATCH] D13869: instruction 'align' in asm blocks works incorrectly with some cases of parameters

[Reid Kleckner via llvm-commits]

rnk added a comment.

Actually, you need to check `MCAsmInfo::getAlignmentIsInBytes()` to decide if this rewrite is or isn't necessary. Some targets use log2 alignment values, and others use power of 2 alignment values.


================
Comment at: lib/MC/MCParser/AsmParser.cpp:4678
@@ -4678,3 +4677,3 @@
 
     unsigned AdditionalSkip = 0;
     // Rewrite expressions in $N notation.
----------------
This is now always zero, so you should zap it.

================
Comment at: lib/MC/MCParser/AsmParser.cpp:4727
@@ -4732,3 +4726,3 @@
     // Skip the original expression.
     AsmStart = Loc + AR.Len + AdditionalSkip;
   }
----------------
This addition is a no-op.


http://reviews.llvm.org/D13869