[PATCH] D13789: [safestack] Fast access to the unsafe stack pointer on AArch64/Android (2nd try).
Renato Golin via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 20 06:36:03 PDT 2015
rengolin added a comment.
Overall, this is less android specific in that only x86_64 and AArch64 knows about it, but the generic target lowering is independent. In that sense, it is better this way than previously.
================
Comment at: lib/Transforms/Instrumentation/SafeStack.cpp:483
@@ -534,1 +482,3 @@
+Value *SafeStack::getOrCreateUnsafeStackPtr(IRBuilder<> &IRB, Function &F) {
+ // Check if there is a target-specific location for the unsafe stack pointer.
----------------
Moving this around makes it harder to review. Can you move it back where it was?
Repository:
rL LLVM
http://reviews.llvm.org/D13789
More information about the llvm-commits
mailing list