[PATCH] D13733: Perform DIV, REM -> DIVREM combining for all affected nodes at once.

[Renato Golin via llvm-commits]

rengolin accepted this revision.
rengolin added a reviewer: rengolin.
rengolin added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:2232
@@ +2231,3 @@
+      if (UserOpc == ISD::SDIV || UserOpc == ISD::UDIV)
+        CombineTo(User, combined);
+      else if (UserOpc == ISD::SREM || UserOpc == ISD::UREM)
----------------
tyomitch wrote:
> tyomitch wrote:
> > rengolin wrote:
> > > Why not getValue(0), here?
> > That's how it was in the original code in LegalizeDAG.cpp
> > 
> > I don't have a particular preference, and I don't mind changing it to getValue(0)
> Any preference here?
Not really. I'll leave it to you to decide. :)


http://reviews.llvm.org/D13733