[PATCH] D13733: Perform DIV, REM -> DIVREM combining for all affected nodes at once.

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 20 05:01:49 PDT 2015


rengolin added a comment.

In http://reviews.llvm.org/D13733#270160, @tyomitch wrote:

> The motivation is to enable http://reviews.llvm.org/D13862 -- I've now set you as a reviewer there, too.


Right, so the patterns that ended up as target-specific (and thus not lowered optimally) were due to that change first?

If that's the case, than this is a fix for the problems raised by that commit, and thus doesn't need any additional tests if, and only if, that patch breaks some tests.

If it does, please commit both at the same time. If not, please provide examples where those patterns got wrong by that patch, and fix them with this patch.

Thanks!


http://reviews.llvm.org/D13733





More information about the llvm-commits mailing list