[PATCH] D13862: Adding support for TargetLoweringBase::LibCall

[Renato Golin via llvm-commits]

rengolin added a comment.

Hi Artyom,

I like this idea a lot. It allows for more flexibility and explicitly states the hierarchy we want, Legal > Expand > Libcall.

LGTM, too. Thanks!


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:150
@@ -149,4 +149,3 @@
 
-  std::pair<SDValue, SDValue> ExpandAtomic(SDNode *Node);
-
-  void ExpandNode(SDNode *Node);
+  bool ExpandNode(SDNode *Node);
+  void ConvertNodeToLibcall(SDNode *Node);
----------------
These two are intrinsically related in the lowering phase, and would be good to have some comments to that effect here, so people can understand without searching for the implementation details.


http://reviews.llvm.org/D13862