[lld] r250775 - [Driver] Error out instead of silently ignoring on invalid -z argument.

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 19 17:34:04 PDT 2015


Author: davide
Date: Mon Oct 19 19:34:04 2015
New Revision: 250775

URL: http://llvm.org/viewvc/llvm-project?rev=250775&view=rev
Log:
[Driver] Error out instead of silently ignoring on invalid -z argument.

This matches what both ld.bfd and gold do.

Modified:
    lld/trunk/ELF/Driver.cpp
    lld/trunk/test/elf2/basic.s

Modified: lld/trunk/ELF/Driver.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Driver.cpp?rev=250775&r1=250774&r2=250775&view=diff
==============================================================================
--- lld/trunk/ELF/Driver.cpp (original)
+++ lld/trunk/ELF/Driver.cpp Mon Oct 19 19:34:04 2015
@@ -164,6 +164,8 @@ void LinkerDriver::createFiles(opt::Inpu
       Config->ZNodelete = true;
     else if (Arg->getValue() == StringRef("now"))
       Config->ZNow = true;
+    else
+      error(Twine(Arg->getValue()) + ": unknown -z option");
   }
 
   for (auto *Arg : Args) {

Modified: lld/trunk/test/elf2/basic.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/elf2/basic.s?rev=250775&r1=250774&r2=250775&view=diff
==============================================================================
--- lld/trunk/test/elf2/basic.s (original)
+++ lld/trunk/test/elf2/basic.s Mon Oct 19 19:34:04 2015
@@ -220,3 +220,6 @@ _start:
 
 # RUN: not ld.lld2 %t -o %t -m wrong_emul 2>&1 | FileCheck --check-prefix=UNKNOWN_EMUL %s
 # UNKNOWN_EMUL: Unknown emulation: wrong_emul
+
+# RUN: not ld.lld2 %t -o %t -z notanoption 2>&1 | FileCheck --check-prefix=UNKNOWN_ZOPT %s
+# UNKNOWN_ZOPT: notanoption: unknown -z option




More information about the llvm-commits mailing list