[llvm] r250749 - [Orc] Use '= default' for move constructor/assignment as per dblaikie's review.

Lang Hames via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 19 15:49:19 PDT 2015


Author: lhames
Date: Mon Oct 19 17:49:18 2015
New Revision: 250749

URL: http://llvm.org/viewvc/llvm-project?rev=250749&view=rev
Log:
[Orc] Use '= default' for move constructor/assignment as per dblaikie's review.

Thanks Dave!

Modified:
    llvm/trunk/include/llvm/ExecutionEngine/Orc/CompileOnDemandLayer.h

Modified: llvm/trunk/include/llvm/ExecutionEngine/Orc/CompileOnDemandLayer.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/Orc/CompileOnDemandLayer.h?rev=250749&r1=250748&r2=250749&view=diff
==============================================================================
--- llvm/trunk/include/llvm/ExecutionEngine/Orc/CompileOnDemandLayer.h (original)
+++ llvm/trunk/include/llvm/ExecutionEngine/Orc/CompileOnDemandLayer.h Mon Oct 19 17:49:18 2015
@@ -69,21 +69,12 @@ private:
 
     LogicalModuleResources() {}
 
-    LogicalModuleResources(LogicalModuleResources &&Other) {
-      SourceModule = std::move(Other.SourceModule);
-      StubsToClone = std::move(StubsToClone);
-      StubsMgr = std::move(StubsMgr);
-    }
-
     // Explicit move constructor to make MSVC happy.
-    LogicalModuleResources& operator=(LogicalModuleResources &&Other) {
-      SourceModule = std::move(Other.SourceModule);
-      StubsToClone = std::move(StubsToClone);
-      StubsMgr = std::move(StubsMgr);
-      return *this;
-    }
+    LogicalModuleResources(LogicalModuleResources &&Other) = default;
 
     // Explicit move assignment to make MSVC happy.
+    LogicalModuleResources& operator=(LogicalModuleResources &&Other) = default;
+
     JITSymbol findSymbol(StringRef Name, bool ExportedSymbolsOnly) {
       if (Name.endswith("$stub_ptr") && !ExportedSymbolsOnly) {
         assert(!ExportedSymbolsOnly && "Stubs are never exported");




More information about the llvm-commits mailing list