[PATCH] D13743: Lazily sort ScopesWithImportedEntities to speed up LTO linking.

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 19 13:58:19 PDT 2015


dblaikie added a comment.

It'd be nice if we could sort immediately after populating - but the issue
you've identified is that we use it within the body of the for(CUs) loop
after we've added them for one CU?

What about if we sunk the data structure down into the DwarfUnit (actually
we should be able to sink it into DwarfCompileUnit - these specific scopes
should never appear in DwarfTypeUnits)? Then we would reduce the size of
the data structure to search through (since each query should know which
unit it's for - effectively bucketizing it) & be able to sort immediately
after populating, since it'll be "populate the map for this CU, sort it,
then never touch it again"?


http://reviews.llvm.org/D13743





More information about the llvm-commits mailing list