[PATCH] D13779: [Polly] Full/partial tile separation for vectorization

[Johannes Doerfert via llvm-commits]

jdoerfert added a comment.

LGTM.


================
Comment at: lib/Transform/ScheduleOptimizer.cpp:210
@@ +209,3 @@
+  ExtConstr = isl_constraint_set_constant_si(ExtConstr, VectorWidth - 1);
+  ExtConstr =
+      isl_constraint_set_coefficient_si(ExtConstr, isl_dim_set, Dims - 1, -1);
----------------
That looks better and provides a constructive desciption of what is happening (instead of the destructive one before). thx!

================
Comment at: lib/Transform/ScheduleOptimizer.cpp:229
@@ +228,3 @@
+/// @param ScheduleRange A range of a map, which describes a prefix schedule
+///                      relation.
+static __isl_give isl_set *
----------------
Would be great yes.


http://reviews.llvm.org/D13779