[PATCH] D13872: [ELF2] - fixed infinite includes depth (in linkerscript)

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 19 09:05:05 PDT 2015


grimar added a comment.

In http://reviews.llvm.org/D13872#270287, @ruiu wrote:

> Adding a marker string to the vector which otherwise contain only real tokens is too hacky. The linker script handler is intentionally dumb and simple. Please leave it alone now.


But I compare adress of first symbols, not the values :

if (Tok.begin() == EndInclude.begin())

That should not affect the real tokens..


http://reviews.llvm.org/D13872





More information about the llvm-commits mailing list