[PATCH] D13870: [ELF2] - Linker script EXTERN implemented.

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/Driver.cpp:192-194
@@ -191,2 +191,5 @@
 
+  for (auto *Arg : Args.filtered(OPT_undefined))
+    Config->Undefined.push_back(Arg->getValue());
+
   if (Files.empty())
----------------
Move this before OPT_z.

================
Comment at: test/elf2/linkerscript.s:9-11
@@ -8,1 +8,5 @@
 
+# RUN: echo "EXTERN( undef undef2 )" > %t.script
+# RUN: ld.lld2 %t -o %t2 %t.script
+# RUN: llvm-readobj %t2 > /dev/null
+
----------------
This test does not actually verify that EXTERN() works in the same way as -u. I'd add one more test to undefined-opt.s.


http://reviews.llvm.org/D13870