[PATCH] D13847: llvm-lto support for generating combined function indexes

[Teresa Johnson via llvm-commits]

tejohnson marked 2 inline comments as done.
tejohnson added a comment.

Thanks for the review. Responses below, will commit fixed patch.


================
Comment at: tools/llvm-lto/llvm-lto.cpp:189
@@ +188,3 @@
+  LLVMContext Context;
+  // Context.setDiagnosticHandler(handleDiagnostics, nullptr, true);
+  std::unique_ptr<FunctionInfoIndex> CombinedIndex(new FunctionInfoIndex());
----------------
joker.eph wrote:
> ?
Cleaned up.

================
Comment at: tools/llvm-lto/llvm-lto.cpp:190
@@ +189,3 @@
+  // Context.setDiagnosticHandler(handleDiagnostics, nullptr, true);
+  std::unique_ptr<FunctionInfoIndex> CombinedIndex(new FunctionInfoIndex());
+  uint64_t NextModuleId = 0;
----------------
joker.eph wrote:
> Could a local variable be enough?
Changed CombinedIndex to a local. This was copied out of my gold-plugin code which I will cleanup similarly in a follow-on commit.


http://reviews.llvm.org/D13847