[PATCH] D13767: [X86] Fix more -Os + EH issues
Michael Kuperstein via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 19 05:49:43 PDT 2015
mkuper added inline comments.
================
Comment at: lib/Target/X86/X86CallFrameOptimization.cpp:503
@@ +502,3 @@
+ if (MF.getMMI().hasDebugInfo())
+ static_cast<const X86FrameLowering *>(TFL)->BuildCFI(MBB, std::next(Push), DL,
+ MCCFIInstruction::createAdjustCfaOffset(nullptr, 4));
----------------
Argh, this should have been a cast<>, not a static_cast<>.
Also, I can avoid this completely and copy the code from the BuildCFI() helper, but I think it's better this way.
http://reviews.llvm.org/D13767
More information about the llvm-commits
mailing list