[llvm] r250376 - [RuntimeDyld] Drop the '.s' suffix off the COFF test case - the MIPS bot started

[Daniel Sanders via llvm-commits]

I've skimmed through RuntimeDyldCOFFX86_64 and there's a few places where it neglects to account for differences between host endian and target endian. If you search for '(uint' you'll find them. It looks like COFF needs to use writeBytesUnaligned() like RuntimeDyldELF.cpp does.

Hope that helps.

From: llvm-commits [mailto:llvm-commits-bounces at lists.llvm.org] On Behalf Of David Blaikie via llvm-commits
Sent: 16 October 2015 22:50
To: Lang Hames
Cc: llvm-commits
Subject: Re: [llvm] r250376 - [RuntimeDyld] Drop the '.s' suffix off the COFF test case - the MIPS bot started



On Thu, Oct 15, 2015 at 12:16 AM, Lang Hames via llvm-commits <llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>> wrote:
Author: lhames
Date: Thu Oct 15 02:16:40 2015
New Revision: 250376

URL: http://llvm.org/viewvc/llvm-project?rev=250376&view=rev
Log:
[RuntimeDyld] Drop the '.s' suffix off the COFF test case - the MIPS bot started
failing when the suffix was added.

I assume the lack of a '.s' suffix means that the test case just wasn't running
before,

Yep, only certain suffixes are actually run as tests, in llvm/test/lit.cfg:

# suffixes: A list of file extensions to treat as test files. This is overriden
# by individual lit.local.cfg files in the test subdirectories.
config.suffixes = ['.ll', '.c', '.cxx', '.test', '.txt', '.s']


and it has never worked on MIPS. I'll investigate that tomorrow.


Added:
    llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/COFF_x86_64
      - copied unchanged from r250371, llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/COFF_x86_64.s
Removed:
    llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/COFF_x86_64.s

Removed: llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/COFF_x86_64.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/COFF_x86_64.s?rev=250375&view=auto
==============================================================================
--- llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/COFF_x86_64.s (original)
+++ llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/COFF_x86_64.s (removed)
@@ -1,34 +0,0 @@
-# RUN: llvm-mc -triple=x86_64-pc-win32 -filetype=obj -o %T/COFF_x86_64.o %s
-# RUN: llvm-rtdyld -triple=x86_64-pc-win32 -verify -check=%s %/T/COFF_x86_64.o
-               .text
-       .def     F;
-       .scl    2;
-       .type   32;
-       .endef
-       .globl  __real400921f9f01b866e
-       .section        .rdata,"dr",discard,__real400921f9f01b866e
-       .align  8
-__real400921f9f01b866e:
-       .quad   4614256650576692846     # double 3.1415899999999999
-       .text
-       .globl  F
-        .global inst1
-       .align  16, 0x90
-F:                                      # @F
-.Ltmp0:
-.seh_proc F
-# BB#0:                                 # %entry
-.Ltmp1:
-       .seh_endprologue
-# rtdyld-check: decode_operand(inst1, 4) = __real400921f9f01b866e - next_pc(inst1)
-inst1:
-       movsd   __real400921f9f01b866e(%rip), %xmm0 # xmm0 = mem[0],zero
-       retq
-.Leh_func_end0:
-.Ltmp2:
-       .seh_endproc
-
-# Make sure the JIT doesn't bail out on BSS sections.
-        .bss
-bss_check:
-        .fill 8, 1, 0


_______________________________________________
llvm-commits mailing list
llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151019/5777df25/attachment.html>