[PATCH] D13733: Perform DIV, REM -> DIVREM combining for all affected nodes at once.

[Renato Golin via llvm-commits]

rengolin added a subscriber: rengolin.
rengolin added a comment.

Hi Artyom,

I was under the impression that these two patches were complete. But if I read right on your description, "This recovers most of the tests broken by the previous patch." means that not all the tests are fixed. Is that correct?

I have done changes in that area before, and I have always met with numerous bugs in tests due to the complicated nature of div/rem on different targets.

I like where your patches are going, but I worry if they're really correct to the other targets.

I'd recommend you to abandon http://reviews.llvm.org/D13732, merge those changes here and make sure that *all* tests pass with flying colours.

cheers,
--renato


http://reviews.llvm.org/D13733