[PATCH] D13857: Fix mapping of @llvm.arm.ssat/usat intrinsics to ssat/usat instructions

Asiri Rathnayake via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 19 02:50:31 PDT 2015


rmaprath added a comment.

In http://reviews.llvm.org/D13857#270028, @rengolin wrote:

> Shouldn't the tests account for the corner cases and validation errors as well?


I did think about this, but couldn't find a way to add such tests. If I put out-of-rage arguments for the intrinsics, instruction selection aborts with:

  Script:
  --
  /work/oss/git/build/./bin/llc -O1 -mtriple=armv6-none-none-eabi /work/oss/git/src/test/CodeGen/ARM/sat-arith.ll -o - | /work/oss/git/build/./bin/FileCheck /work/oss/git/src/test/CodeGen/ARM/sat-arith.ll
  --
  Exit Code: 2
  
  Command Output (stderr):
  --
  LLVM ERROR: Cannot select: intrinsic %llvm.arm.ssat
  FileCheck error: '-' is empty.
  
  --

And that completely kills the test (no further tests will execute). Any suggestions?

Thanks.


Repository:
  rL LLVM

http://reviews.llvm.org/D13857





More information about the llvm-commits mailing list