[PATCH] D13842: [CMake] Get rid of LLVM_DYLIB_EXPORT_ALL, and make it the default, add libLLVM-C on darwin to cover the C API needs.

[Chris Bieneman via llvm-commits]

beanz added a comment.

Thanks for the feedback. Updated patches incoming.


================
Comment at: CMakeLists.txt:376
@@ -375,3 +375,3 @@
 endif()
-option(LLVM_LINK_LLVM_DYLIB "Link tools against the libllvm dynamic library" OFF)
+option(LLVM_LINK_LLVM_DYLIB "Link tools against the libllvm dynamic library" ON)
 option(LLVM_BUILD_LLVM_DYLIB "Build libllvm dynamic library" ${LLVM_LINK_LLVM_DYLIB})
----------------
axw wrote:
> Did you mean to make this change? It's a pretty big change, and probably warrants some discussion on llvm-dev.
That was unintentional, but I do actually need to clean up how we set some of the defaults here. I think the default value for LLVM_BUILD_LLVM_DYLIB should effectively be `LLVM_LINK_LLVM_DYLIB OR LLVM_BUILD_LLVM_C_DYLIB`.


http://reviews.llvm.org/D13842