[PATCH] D13838: [elf2] Don't allocate VA space for TLS NOBITS sections.
Rafael Ávila de Espíndola via llvm-commits
llvm-commits at lists.llvm.org
Sat Oct 17 06:05:17 PDT 2015
rafael added a comment.
I am OK with the test update.
Just make sure Rui is OK with the refactoring he asked for.
================
Comment at: test/elf2/tls.s:83
@@ +82,3 @@
+
+// Check that the TLS NOBITS sections weren't added to the R/W PT_LOAD's size.
+
----------------
Make this check a tiny bit stronger. You know which PT_LOAD this is, so you can do
// CHECK: PT_LOAD
// CHECK: PT_LOAD
// CHECK: PT_LOAD
....
To make sure you skip the RO and RW segments.
http://reviews.llvm.org/D13838
More information about the llvm-commits
mailing list