[PATCH] D13487: [Polly] Load/Store scalar accesses before/after the statement itself

[Tobias Grosser via llvm-commits]

grosser added a comment.

Hi Michael,

besides one minor comment this patch looks now good to me.

Best,
Tobias


================
Comment at: lib/CodeGen/BlockGenerators.cpp:1114
@@ +1113,3 @@
+    // Implicit writes induced by PHIs must be written in the incoming blocks.
+    if (isa<TerminatorInst>(ScalarInst)) {
+      BasicBlock *ExitingBB = ScalarInst->getParent();
----------------
Was there a specific reason you moved away from the MA->isPHI()? Your new code seems to be functional equivalent, as TerminatorInstructions are only used as memory access instructions for PHI nodes, but I find this less clear than MA->isPHI().


http://reviews.llvm.org/D13487