[lld] r250555 - [ELF2] getLocalRelTarget should handle R_PPC64_TOC directly

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 16 15:21:33 PDT 2015


----- Original Message -----
> From: "Rafael EspĂ­ndola" <rafael.espindola at gmail.com>
> To: "Hal Finkel" <hfinkel at anl.gov>
> Cc: "llvm-commits" <llvm-commits at lists.llvm.org>
> Sent: Friday, October 16, 2015 5:20:20 PM
> Subject: Re: [lld] r250555 - [ELF2] getLocalRelTarget should handle R_PPC64_TOC directly
> 
> > -                             const typename ELFFile<ELFT>::Elf_Rel
> > &RI) {
> > +                             const typename ELFFile<ELFT>::Elf_Rel
> > &RI,
> > +                             uint32_t Type) {
> 
> You can get the type with
> 
>  RI.getType(IsMips64EL)
> 
> Why the extra argument?

I either need to pass Type or IsMips64EL, right?

 -Hal

> 
> Cheers,
> Rafael
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory


More information about the llvm-commits mailing list