[PATCH] D13828: Do not process __config file in C mode

Eric Fiselier via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 16 14:54:17 PDT 2015


EricWF added a comment.

You shouldn't be including the C++ standard library using `-I`, especially if your doing it during C compilation. Chrome will continue to build if you replace `-I path/to/libcxx/include` with `-cxx-isystem path/to/libcxx/include`.

I'll continue to look into interactions between `<__config>` and `extern "C"`, but it's simply incorrect to use libc++ during C compilation. There is a reason the clang driver doesn't add the libc++ include paths during C compilation and Chrome must do the same.


http://reviews.llvm.org/D13828





More information about the llvm-commits mailing list