[PATCH] D13824: [llvm-readobj] Teach ELFDumper about symbol versioning

[Rafael Ávila de Espíndola via llvm-commits]

rafael accepted this revision.
rafael added a comment.
This revision is now accepted and ready to land.

LGTM with nits.

Gosh, this is a crazy format.


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:313
@@ +312,3 @@
+    const Elf_Shdr *Sec = dot_gnu_version_sec;
+    if (Sec) {
+      StringRef Name = errorOrDefault(Obj->getSectionName(Sec));
----------------
With a helper function to dump just the symbol section you could use an early return :-)

================
Comment at: tools/llvm-readobj/ELFDumper.cpp:342
@@ +341,3 @@
+    const Elf_Shdr *Sec = dot_gnu_version_d_sec;
+    if (Sec) {
+      StringRef Name = errorOrDefault(Obj->getSectionName(Sec));
----------------
Same here.

================
Comment at: tools/llvm-readobj/ELFDumper.cpp:366
@@ +365,3 @@
+        if (P + sizeof(Elf_Verdef) > SecEndAddress)
+          report_fatal_error("invalid offset in the section");
+        auto *VD = reinterpret_cast<const Elf_Verdef *>(P);
----------------
I think you can use just error.


http://reviews.llvm.org/D13824