[PATCH] D13832: [ELF2/AArch64] Comment R_AARCH64_ADD_ABS_LO12_NC relocation

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 16 14:04:21 PDT 2015


LGTM. If there are more of these we might want to add write12
functions, but for now this should do it.

On 16 October 2015 at 16:52, Davide Italiano <dccitaliano at gmail.com> wrote:
> davide created this revision.
> davide added a reviewer: rafael.
> davide added a subscriber: llvm-commits.
> Herald added subscribers: rengolin, aemerson.
>
> Quick sanity (and english) check.
>
> http://reviews.llvm.org/D13832
>
> Files:
>   Target.cpp
>
> Index: Target.cpp
> ===================================================================
> --- Target.cpp
> +++ Target.cpp
> @@ -632,6 +632,10 @@
>      break;
>    case R_AARCH64_ADD_ABS_LO12_NC:
>      // No overflow check needed.
> +    // This relocation stores 12 bits and there's no instruction
> +    // to do it. Instead, we do a 32 bits store of the value
> +    // of r_addend bitwise-or'ed L. This assumes that the addend
> +    // bits in L are zero.
>      or32le(L, (SA & 0xFFF) << 10);
>      break;
>    case R_AARCH64_ADR_PREL_LO21: {
>
>


More information about the llvm-commits mailing list