[PATCH] D13823: [ELF2] getLocalRelTarget can ask the Target for symbolless relocations

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/OutputSections.cpp:434
@@ -432,3 +433,3 @@
   // For certain special relocations, such as R_PPC64_TOC, there's no
   // corresponding symbol. Just return 0 in that case.
   if (!Sym)
----------------
Update the comment to mention that we usually return 0 but may be different on PPC64.

But, actually, does this happen on non-PPC64 platform? If there's no other platform that we have to take care of this case, this is probably over-designed. We can define a function like getPPC64TocDefault() and use that function here if it's on PPC64.

================
Comment at: ELF/Target.cpp:439
@@ +438,3 @@
+    return getPPC64TocBase();
+
+  return 0;
----------------
Remove this blank line.


http://reviews.llvm.org/D13823